Skip to content

Make Runner an abstract base class #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

pakrym-oai
Copy link
Contributor

No description provided.

- Introduce a DEFAULT_RUNNER global and a set_default_runner() function to allow callers to specify a default Runner for agent runs.
- Update Runner.run, run_sync, and run_streaming to use DEFAULT_RUNNER if set, otherwise fallback to DefaultRunner.
- Add detailed docstrings to run, run_sync, and run_streaming methods for clarity on agent execution flow and exceptions.
This commit renames the abstract and concrete methods run_impl, run_sync_impl, and run_streamed_impl in the Runner and DefaultRunner classes to _run_impl, _run_sync_impl, and _run_streamed_impl (or _start_streaming as appropriate) for improved naming consistency. Updates all method calls and test mocks accordingly. No behavior changes.
…lace global with accessor

- Move TraceProvider and related logic from setup.py to new provider.py module
- Replace direct GLOBAL_TRACE_PROVIDER references with get_trace_provider() accessor throughout tracing code
- Update init and util imports to use get_trace_provider
- Call set_trace_provider(TraceProvider()) on init
- Remove ID and time generation logic from util, delegate to TraceProvider
- Update SpanImpl to always use passed-in span_id
Copy link

github-actions bot commented Jun 1, 2025

This PR is stale because it has been open for 10 days with no activity.

@github-actions github-actions bot added the stale label Jun 1, 2025
Copy link

github-actions bot commented Jun 9, 2025

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Jun 9, 2025
…mplementation

- Add abstract TraceProvider base class to define tracing API
- Move default tracing logic to DefaultTraceProvider
- Update __init__.py to export both TraceProvider and DefaultTraceProvider, and use DefaultTraceProvider as default
- Aligns span/trace management and enables alternative provider implementations
# Conflicts:
#	src/agents/__init__.py
#	src/agents/run.py
@pakrym-oai pakrym-oai reopened this Jun 11, 2025
…itialized

- Add get_default_runner to retrieve current default runner.
- Always assign DEFAULT_RUNNER to a DefaultRunner at module init.
- Replace fallback logic (`DEFAULT_RUNNER or DefaultRunner()`) with direct use of initialized DEFAULT_RUNNER.
- Update __all__ in __init__.py to export get_default_runner.
- Minor update to tracing/__init__.py __all__ for consistency.
…ls, _get_model) from DefaultRunner to Runner base class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant