Skip to content

Clone options fully for ChatCompletion calls #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christothes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clone options fully for ChatCompletion calls #861

christothes wants to merge 1 commit into from

Conversation

@christothes
Copy link
Collaborator

@christothes christothes commented Dec 8, 2025

fixes #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Race Condition: ChatClient.CompleteChatAsync Mutates Shared ChatCompletionOptions, Causing Incorrect Request Payloads in Parallel Calls

1 participant

@christothes