Conversation
- Replace strcpy with g_strlcpy for license plate strings (buffer overflow) - Add NULL check after DsOpenalprCtx_Init - Free cvmat and cached_results on error path (memory leaks) - Replace assert with proper error handling and logging - Update deprecated CV_RGBA2BGR to cv::COLOR_RGBA2BGR - Add -Wall and -fstack-protector-strong to Makefile CFLAGS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strcpywithg_strlcpyfor license plate strings (buffer overflow fix)DsOpenalprCtx_Initto prevent NULL derefcvmatandcached_resultson error path (memory leak fix)assert()with proper error handling and GST_WARNING loggingCV_RGBA2BGRtocv::COLOR_RGBA2BGR-Wall -fstack-protector-strongto Makefile CFLAGSTest plan
Shortcut: https://app.shortcut.com/rekor/story/158713
🤖 Generated with Claude Code