Genaral website update/overhaul #22
Conversation
- Added `rel="noopener"` to every link - Updated outdated links - Removed trailing slashes
- Added `rel="noopener"` to every link - Updated outdated links - Removed trailing slashes - Removed dead links
These buttons replace the old two links and add Liberapay.
MagicLike
added
bug
Added border radius to more website elements to fit theme
|
Are you sure the new workflow works? Also, it would be great if the build and deployment would be triggered by adding commits to the main branch, and not only through PRs. |
fixed! |
I tested it multiple times, it should work... |
|
I'm planning to push the next release of the Installer on Friday (next week) and then publish this PR. Thanks a lot for cleaning and improving the website! 😊 |
No problem! :D - But there is still stuff to do after that ^^ |
MagicLike
changed the title
|
Did you test the new github workflow? Because every time I touch this stuff something breaks if I don't test it. |
I did - multiple times, One example can be seen here: https://github.com/Magic-Tests/openandroidinstaller-dev.github.io/actions But if you feel uncomfortable about it, feel free to not include it for now! |
Okay great, great! 😊 looks perfect 👏 thank you for clarifying.
No, I want it in and it looks solid 🙂 |
|
The build workflow didn't work properly, since it has no permission to push to main. I guess this is a general issue and cannot be avoided if the main branch is protected and only allows commits through PRs... Maybe pushing to the deployment branch might work? I'm not sure |
I'm gonna do some research later 🤔 |
Seems to be an annoying issue :D But other than that it would have worked great! And it also looks great now, thanks a lot :) |
Hmmm it should be possible for you to allow the Actions user to commit directly to main in the branch protection section 🤔 (Should be |
Where did you get that info from? My understanding was, that has been removed, since it technically allows to bypass branch protection for anyone who can create branches on the repo. |
I made a quick search and found this: https://overflow.adminforge.de/questions/69263843/how-to-push-to-protected-main-branches-in-a-github-action#72515781 |
Going forward, this will allow anyone allowed to create branches on the repo to basically commit with admin privileges. And some comments say it doesn't even work. I guess I rather prefer to just have html commited in the public folder on main deployed? Seems very easy and I build the files locally first either way. 🤔 I will think about it |
wait, there should also be an option to let GH Actions run alongside a PR, for example, when it gets approved it will build the website on the PR branch and then it can get merged... |
That would be great I guess :) |
That should also be possible... - But I will need to investigate that further in the next few days (I have never done that before) |
rel="noopener"to every link