Skip to content

Fix input element not displaying file in Create Event#1529

Merged
gregorydlogan merged 1 commit intoopencast:r/19.xfrom
Arnei:forgetful-file-input
Mar 18, 2026
Merged

Fix input element not displaying file in Create Event#1529
gregorydlogan merged 1 commit intoopencast:r/19.xfrom
Arnei:forgetful-file-input

Conversation

@Arnei
Copy link
Member

@Arnei Arnei commented Mar 17, 2026

Fixes #946.

If you open the create event modal and upload a file in the source tab, switch to a different tab and then switch back to the source tab, the name of the uploaded file will not be displayed, even though the file is actually uploaded.
While this is just a visual bug, it can be very confusing for users.

This patch fixes the issue by adding some html and css to fake the look of an input dialog, instead of relying on the native implementation. This gives us full control of what the user sees. Afaik it is also necessary, because browsers will not allow feeding an exisiting file handle into a file
upload input.

Bildschirmfoto vom 2026-03-17 14-47-40

How to test this

Can be tested as is. Experiment with uploading and removing files, and moving between different tabs.

If you open the create event modal and upload a file in the source tab,
switch to a different tab and then switch back to the source tab,
the name of the uploaded file will not be displayed, even though the
file is actually uploaded.
While this is just a visual bug, it can be very confusing for users.

This patch fixes the issue by adding some html and css to fake
the look of an input dialog, instead of relying on the native
implementation. This gives us full control of what the user sees.
Afaik it is also necessary, because browsers will not allow feeding
an exisiting file handle into a file
upload input.
@Arnei Arnei added the type:bug Something isn't working label Mar 17, 2026
@github-actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1529

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1529

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1529/2026-03-17_13-50-15/ .
It might take a few minutes for it to become available.

@gregorydlogan gregorydlogan self-assigned this Mar 18, 2026
@gregorydlogan gregorydlogan merged commit cdffd19 into opencast:r/19.x Mar 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants