Fix input element not displaying file in Create Event#1529
Merged
gregorydlogan merged 1 commit intoopencast:r/19.xfrom Mar 18, 2026
Merged
Fix input element not displaying file in Create Event#1529gregorydlogan merged 1 commit intoopencast:r/19.xfrom
gregorydlogan merged 1 commit intoopencast:r/19.xfrom
Conversation
If you open the create event modal and upload a file in the source tab, switch to a different tab and then switch back to the source tab, the name of the uploaded file will not be displayed, even though the file is actually uploaded. While this is just a visual bug, it can be very confusing for users. This patch fixes the issue by adding some html and css to fake the look of an input dialog, instead of relying on the native implementation. This gives us full control of what the user sees. Afaik it is also necessary, because browsers will not allow feeding an exisiting file handle into a file upload input.
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1529/2026-03-17_13-50-15/ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #946.
If you open the create event modal and upload a file in the source tab, switch to a different tab and then switch back to the source tab, the name of the uploaded file will not be displayed, even though the file is actually uploaded.
While this is just a visual bug, it can be very confusing for users.
This patch fixes the issue by adding some html and css to fake the look of an input dialog, instead of relying on the native implementation. This gives us full control of what the user sees. Afaik it is also necessary, because browsers will not allow feeding an exisiting file handle into a file
upload input.
How to test this
Can be tested as is. Experiment with uploading and removing files, and moving between different tabs.