fix: unwrap edited messages during history sync parsing#246
Open
hiasinho wants to merge 2 commits into
Open
Conversation
Author
|
One possible follow-up to make this PR stronger: add regression assertions for the two edge cases handled here too — preserving wrapper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProtocolMessage_MESSAGE_EDITand top-levelEditedMessageFixes #245.
Behavior note
This fixes parsing for edited messages when they are received by
wacliduring future history sync, fresh initial sync, or backfill events.It does not automatically repair existing rows already stored as:
Those rows need to be re-delivered by WhatsApp, for example through a fresh linked-device sync, before this parser fix can recover the edited body.
Testing
go test ./internal/wa ./internal/app ./internal/store ./cmd/wacliAlso tested against a fresh linked-device sync: edited messages that were previously stored as
(message)were recovered with their text bodies.