Update DASH eni & port counters#2251
Conversation
arunp-dev
force-pushed
the
dash-counters
branch
from
4569c64 to
b58ddab
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@marian-pritsak for review |
There was a problem hiding this comment.
Pull request overview
This pull request updates DASH (Disaggregated API for SONiC Hosts) counters for ENI (Elastic Network Interface) and port statistics based on requirements from sonic-net/SONiC issue #2139. The PR adds comprehensive telemetry capabilities for tracking session management, TCP state transitions, traffic drops, and High Availability (HA) synchronization.
Changes:
- Added FINACK acronym definition to meta/acronyms.txt
- Added 5 new port-level drop counters in experimental/saiportextensions.h
- Added 65 new ENI statistics covering session tracking, TCP state management, drop reasons, and HA sync metrics in experimental/saiexperimentaldasheni.h
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| meta/acronyms.txt | Added FINACK (TCP FINish ACKnowledgment) acronym for use in counter documentation |
| experimental/saiportextensions.h | Added 5 new port-level drop packet counters for invalid UDP source ports, session table full, invalid sessions, invalid mirror sessions, and IP fragments |
| experimental/saiexperimentaldasheni.h | Added 65 new ENI statistics including active session tracking by protocol, session lifecycle counters, TCP state tracking, CPS metrics, various drop reasons, and HA inline sync counters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@arunp-dev , can you please rebase to latest master |
update DASH counters (from sonic-net/SONiC#2139) Signed-off-by: arun p <arunp@pensando.io>
arunp-dev
force-pushed
the
dash-counters
branch
from
64ac965 to
3e457d9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@vivekrnv @marian-pritsak Can you please help to review? |
|
@dgsudharsan, @vivekrnv , merging to unblock build, let me know if you've any feedback and can be addressed as follow-up PRs |
|
@marian-pritsak and @itaibaz Can you please review and share if you have any concerns? |
This pull request updates DASH (Disaggregated API for SONiC Hosts) counters for ENI (Elastic Network Interface) and port statistics based on requirements from sonic-net/SONiC issue #2139. The PR adds comprehensive telemetry capabilities for tracking session management, TCP state transitions, traffic drops, and High Availability (HA) synchronization.
Changes:
Added FINACK acronym definition to meta/acronyms.txt
Added 5 new port-level drop counters in experimental/saiportextensions.h
Added 65 new ENI statistics covering session tracking, TCP state management, drop reasons, and HA sync metrics in experimental/saiexperimentaldasheni.h