Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to use pidfd and epoll to wait init process exit #4517

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Try to use pidfd and epoll to wait init process exit #4517

wants to merge 3 commits into from
+99 −28

Commits on Nov 9, 2024

  1. libct: replace unix.Kill with os.Process.Signal 

    Because we should switch to unix.PidFDSendSignal in new kernels, it has
been supported in go runtime. We don't need to add fall back to
unix.Kill code here.

Signed-off-by: lfbzhm <[email protected]>
    @lifubang
    lifubang committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    7824bc5 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. libct: use pidfd and epoll to wait the init process exit 

    Signed-off-by: lfbzhm <[email protected]>
    @lifubang
    lifubang committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    794e633 View commit details
    Browse the repository at this point in the history

  2. libct: reduce the delete delay 

    When using unix.Kill to kill the container, we need a for loop to detect
the init process exited or not manually, we sleep 100ms each time in the
current, but for stopped containers or containers running in a low load
machine, we don't need to wait so long time. This change will reduce the
delete delay in some situations, especially for those pods with many
containers in.

Co-authored-by: Abel Feng <[email protected]>
Signed-off-by: lfbzhm <[email protected]>
    @abel-von @lifubang
    abel-von authored and lifubang committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7833912 View commit details
    Browse the repository at this point in the history