-
Notifications
You must be signed in to change notification settings - Fork 570
Add step to update website after a release #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sudo-bmitch
wants to merge
1
commit into
opencontainers:main
Choose a base branch
from
sudo-bmitch:pr-release-notice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,12 +29,12 @@ To avoid unfortunate side effects (onerous backwards compatibility requirements | |
|
||
Every OCI specification project SHOULD hold meetings that involve maintainers reviewing pull requests, debating outstanding issues, and planning releases. | ||
This meeting MUST be advertised on the project README and MAY happen on a phone call, video conference, or on IRC. | ||
Maintainers MUST send updates to the [email protected] with results of these meetings. | ||
Maintainers MUST send updates to the <[email protected]> with results of these meetings. | ||
|
||
Before the specification reaches v1.0.0, the meetings SHOULD be weekly. | ||
Once a specification has reached v1.0.0, the maintainers may alter the cadence, but a meeting MUST be held within four weeks of the previous meeting. | ||
|
||
The release plans, corresponding milestones and estimated due dates MUST be published on GitHub (e.g. https://github.com/opencontainers/runtime-spec/milestones). | ||
The release plans, corresponding milestones and estimated due dates MUST be published on GitHub (e.g. <https://github.com/opencontainers/runtime-spec/milestones>). | ||
GitHub milestones and issues are only used for community organization and all releases MUST follow the [project governance](GOVERNANCE.md) rules and procedures. | ||
|
||
### Timelines | ||
|
@@ -48,8 +48,6 @@ Specifications have a variety of different timelines in their lifecycle. | |
For example if a breaking change is introduced in v1.0.0-rc2 then the series would end with v1.0.0-rc4 and v1.0.0. | ||
* Minor and patch releases SHOULD be made on an as-needed basis. | ||
|
||
[charter]: https://github.com/opencontainers/tob/blob/main/CHARTER.md | ||
|
||
## Checklist | ||
|
||
Releases usually follow a few steps: | ||
|
@@ -65,14 +63,15 @@ Releases usually follow a few steps: | |
* [ ] drop hash and indent, `:'<,'> s/^\w* /^I* /` | ||
* [ ] a commit bumping `./specs-go/version.go` to next version and empty the `VersionDev` variable | ||
* [ ] a commit adding back the "+dev" to `VersionDev` | ||
* [ ] send email to [email protected] | ||
* [ ] send email to <[email protected]> | ||
* [ ] copy the exact commit hash for bumping the version from the pull-request (since master always stays as "-dev") | ||
* [ ] count the PRs since last release (that this version is tracking, in the cases of multiple branching), like `git log --pretty=oneline --no-merges --decorate $priorTag..$versionBumpCommit | grep \(pr\/ | wc -l` | ||
* [ ] get the date for a week from now, like `TZ=UTC date --date='next week'` | ||
* [ ] OPTIONAL find a cute animal gif to attach to the email, and subsequently the release description | ||
* [ ] subject line like `[runtime-spec VOTE] tag $versionBumpCommit as $version (closes $dateWeekFromNowUTC)` | ||
* [ ] email body like | ||
``` | ||
|
||
```text | ||
Hey everyone, | ||
|
||
There have been $numPRs PRs merged since $priorTag release (https://github.com/opencontainers/runtime-spec/compare/$priorTag...$versionBumpCommit). | ||
|
@@ -83,14 +82,18 @@ Please respond LGTM or REJECT (with reasoning). | |
|
||
$sig | ||
``` | ||
* [ ] edit/update the pull-request to link to the VOTE thread, from https://groups.google.com/a/opencontainers.org/forum/#!forum/dev | ||
|
||
* [ ] edit/update the pull-request to link to the VOTE thread, from <https://groups.google.com/a/opencontainers.org/forum/#!forum/dev> | ||
* [ ] a week later, if the vote passes, merge the PR | ||
* [ ] `git tag -s $version $versionBumpCommit` | ||
* [ ] `git push --tags` | ||
* [ ] produce release documents | ||
* [ ] git checkout the release tag, like `git checkout $version` | ||
* [ ] `make docs` | ||
* [ ] rename the output PDF and HTML file to include version, like `mv output/oci-runtime-spec.pdf output/oci-runtime-spec-$version.pdf`` | ||
* [ ] attach these docs to the release on https://github.com/opencontainers/runtime-spec/releases | ||
* [ ] attach these docs to the release on <https://github.com/opencontainers/runtime-spec/releases> | ||
* [ ] link to the the VOTE thread and include the passing vote count | ||
* [ ] link to the pull request that merged the release | ||
* [ ] add release notes to the website <https://github.com/opencontainers/opencontainers.org/tree/main/content/release-notices> | ||
|
||
[charter]: https://github.com/opencontainers/tob/blob/main/CHARTER.md |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IP stuff seems complicated https://github.com/opencontainers/opencontainers.org/blob/main/content/release-notices/v1-0-2-runtime-spec.md , not sure if this should be written by spec maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of it looks like a copy/paste from previous releases. @amye may know more about what maintainers should handle vs LF.