remove unneeded indent #937

Mashimiao · 2017-12-01T03:54:11Z

Signed-off-by: Ma Shimiao [email protected]

Some indents will cause erorr, we should remove them.
Some places are similar with #936

wking · 2017-12-01T06:22:58Z

RELEASES.md

@@ -46,6 +46,6 @@ Specifications have a variety of different timelines in their lifecycle.
    This means a major release like a v1.0.0 or v2.0.0 release will take 1 month at minimum: one week for rc1, one week for rc2, one week for rc3, and one week for the major release itself.
    Maintainers SHOULD strive to make zero breaking changes during this cycle of release candidates and SHOULD restart the three-candidate count when a breaking change is introduced.
    For example if a breaking change is introduced in v1.0.0-rc2 then the series would end with v1.0.0-rc4 and v1.0.0.
- Minor and patch releases SHOULD be made on an as-needed basis.
+* Minor and patch releases SHOULD be made on an as-needed basis.


Nice. I've submitted this upstream with opencontainers/project-template#40.

wking · 2017-12-01T06:26:17Z

config-linux.md

 * **`architectures`** *(array of strings, OPTIONAL)* - the architecture used for system calls.
    A valid list of constants as of libseccomp v2.3.2 is shown below.
-


Why are you removing this line? A blank line before and after a Markdown list is traditional, and it renders fine.

I removed them, because the blank line does not make sense.
But if it's traditional, I will keep them.

wking · 2017-12-01T06:26:53Z

config-linux.md

    * **`names`** *(array of strings, REQUIRED)* - the names of the syscalls.
        `names` MUST contain at least one entry.
    * **`action`** *(string, REQUIRED)* - the action for seccomp rules.
        A valid list of constants as of libseccomp v2.3.2 is shown below.
-


I think we want to keep this pre-list (and the later post-list) blank lines too. There are a number of other instances of this as well.

wking · 2017-12-01T06:30:03Z

glossary.md

@@ -34,5 +34,4 @@ On Linux, the namespaces from which new [container namespaces](#container-namesp

 [JSON]: https://tools.ietf.org/html/rfc7159
 [UTF-8]: http://www.unicode.org/versions/Unicode8.0.0/ch03.pdf
-


From the style docs:

Referenced links should be kept in two alphabetically sorted sets, a general reference section followed by a man page section.

I'm fine dropping that and going to a single alphabetically sorted list, but if we want to do that we should also update the style docs. I'm also fine keeping the separation and the blank line here.

If styles requries, by now I have no intention to change it. Let's keep where it was.

Mashimiao · 2017-12-01T06:40:45Z

updated based on comments, PTAL

TomSweeneyRedHat · 2017-12-01T15:17:09Z

LGTM, nice touch ups.

wking · 2017-12-01T18:13:15Z

config-linux.md


+    A valid list of constants as of libseccomp v2.3.2 is shown below.


I think you want to keep this line where it was (as part of the initial paragraph, with a blank line after it separating the sub-list).

wking · 2017-12-01T18:15:57Z

config-linux.md

    While this property is OPTIONAL, some values of `defaultAction` are not useful without `syscalls` entries.
    For example, if `defaultAction` is `SCMP_ACT_KILL` and `syscalls` is empty or unset, the kernel will kill the container process on its first syscall.
-


I think this “you'll probably want to set this” text is worth keeping in its own paragraph. But I don't feel too strongly about it, and am ok with all of this getting squashed into a single paragraph like you're doing here.

Signed-off-by: Ma Shimiao <[email protected]>

vbatts · 2018-04-04T22:10:40Z

rebase please. This LGTM.

vbatts · 2019-12-17T18:56:51Z

house keeping: if someone else wants to pick up these commits and rebase, feel free to. It's been 1.5yrs needing only a rebase.

h-vetinari · 2020-02-05T07:58:47Z

config-linux.md

-    If `l3CacheSchema` is set, runtimes MUST write the value to the `schemata` file in the `<container-id>` directory discussed in `intelRdt`.
-
-    If `l3CacheSchema` is not set, runtimes MUST NOT write to `schemata` files in any `resctrl` pseudo-filesystems.
+    * If `l3CacheSchema` is set, runtimes MUST write the value to the `schemata` file in the `<container-id>` directory discussed in `intelRdt`.
+    * If `l3CacheSchema` is not set, runtimes MUST NOT write to `schemata` files in any `resctrl` pseudo-filesystems.


Tagging this for reference in rebased PR #1031

Rebase #937

tianon · 2020-02-05T21:43:49Z

Rebased/merged in #1031 👍

Thanks!

Mashimiao mentioned this pull request Dec 1, 2017

config*: Dedent paragraphs that aren't a list entry #938

Closed

wking mentioned this pull request Dec 1, 2017

RELEASES: Use an asterix bullet for "Minor and patch releases..." opencontainers/project-template#40

Merged

wking reviewed Dec 1, 2017

View reviewed changes

Mashimiao force-pushed the remove-indent branch from 565a003 to 21b4492 Compare December 1, 2017 06:40

Mashimiao force-pushed the remove-indent branch from 21b4492 to 1c14b2f Compare December 1, 2017 06:47

wking reviewed Dec 1, 2017

View reviewed changes

Mashimiao force-pushed the remove-indent branch from 1c14b2f to c3f81db Compare December 2, 2017 02:10

remove unneeded indent

c3f81db

Signed-off-by: Ma Shimiao <[email protected]>

wking mentioned this pull request Dec 7, 2017

RFC: config-linux: add an initial spec of RDMA related field #930

Closed

h-vetinari mentioned this pull request Feb 3, 2020

Tag a new release #1010

Closed

h-vetinari reviewed Feb 5, 2020

View reviewed changes

h-vetinari mentioned this pull request Feb 5, 2020

Rebase #937 #1031

Merged

tianon added a commit that referenced this pull request Feb 5, 2020

Merge pull request #1031 from h-vetinari/rebase_937

39c287c

Rebase #937

tianon closed this Feb 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove unneeded indent #937

remove unneeded indent #937

Mashimiao commented Dec 1, 2017

wking Dec 1, 2017

wking Dec 1, 2017

Mashimiao Dec 1, 2017

wking Dec 1, 2017

wking Dec 1, 2017

Mashimiao Dec 1, 2017

Mashimiao commented Dec 1, 2017

TomSweeneyRedHat commented Dec 1, 2017

wking Dec 1, 2017

Mashimiao Dec 2, 2017

wking Dec 1, 2017

vbatts commented Apr 4, 2018

vbatts commented Dec 17, 2019

h-vetinari Feb 5, 2020 •

edited

Loading

tianon commented Feb 5, 2020

		* `architectures` (array of strings, OPTIONAL) - the architecture used for system calls.
		A valid list of constants as of libseccomp v2.3.2 is shown below.

		@@ -34,5 +34,4 @@ On Linux, the namespaces from which new [container namespaces](#container-namesp

		[JSON]: https://tools.ietf.org/html/rfc7159
		[UTF-8]: http://www.unicode.org/versions/Unicode8.0.0/ch03.pdf

		While this property is OPTIONAL, some values of `defaultAction` are not useful without `syscalls` entries.
		For example, if `defaultAction` is `SCMP_ACT_KILL` and `syscalls` is empty or unset, the kernel will kill the container process on its first syscall.

remove unneeded indent #937

remove unneeded indent #937

Conversation

Mashimiao commented Dec 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mashimiao commented Dec 1, 2017

TomSweeneyRedHat commented Dec 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vbatts commented Apr 4, 2018

vbatts commented Dec 17, 2019

h-vetinari Feb 5, 2020 • edited Loading

Choose a reason for hiding this comment

tianon commented Feb 5, 2020

h-vetinari Feb 5, 2020 •

edited

Loading