Merged
Conversation
In some of the ecc API functions, the buffer length parameters are of type `unsigned int`. All other API components use `size_t` for such length parameters. To harmonize with these other APIs, change all length parameter in ecc functions to type `size_t`. Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
The target architecture is different from the host architecture in cross-builds. Add the correct information to the s390x toolchain file. Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
To follow the structure for other sections in the cmake definition, a comment header is added for the test section. Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
Add line-breaks to the contribution rules to increase the readability without a markdown-reader. Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
holger-dengler
requested review from
fcallies and
ifranzki
and removed request for
fcallies
ifranzki
approved these changes
Apr 13, 2026
Contributor
ifranzki
left a comment
ifranzki
left a comment
There was a problem hiding this comment.
OK, if the changes from commit 1 only go into V2, since this breaks the API/ABI.
Contributor
Author
|
There is a new branch libzpc-1.5.y for fixes and maintenance of the "old" libzpc API. All work regarding the new provider API will go into the main branch. |
Contributor
Author
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers a few cleanups as preparation for the provider support. The most important one is the harmonization of the zpc API. As it breaks the former external API it will only go into v2 (and not in any of the libzpc1.* maintenance branches).