fix: include downloaded path in persist_downloaded_model_config warning - #5208
Open
kapil971390 wants to merge 1 commit into
Open
fix: include downloaded path in persist_downloaded_model_config warning#5208kapil971390 wants to merge 1 commit into
kapil971390 wants to merge 1 commit into
Conversation
When download_and_modify_json fails (e.g. disk full, permission error), the warning now tells the user exactly where the models landed and shows the JSON snippet they need to add manually to avoid a redundant re-download on the next run. Add five unit tests covering success, failure (OSError/PermissionError), no-raise guarantee, and both pipeline/vlm repo_mode variants.
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While reviewing recent commits, I noticed that when
persist_downloaded_model_configfails (e.g. disk full, permission error, network issue fetching the config template), the existing warning only logs the exception message:The models themselves were downloaded successfully, but the path is never written to
models-dirin the config. On the next run,get_existing_configured_model_rootfinds no config entry and falls through to_snapshot_download_cached, triggering a full re-download — silently, with no indication of why.Modification
Extended the warning message in
persist_downloaded_model_configto include:model_root)Example of the new warning:
No logic changes — the exception is still caught and the download result is still returned normally.
BC-breaking
No. This is a warning message change only. All existing behaviour is preserved.
Checklist
Before PR:
After PR: