feat: add offset pagination to find - #5337
Open
Eijnewgnaw wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
Hi maintainers, just a gentle follow-up when you have a chance. This PR addresses #5301 with end-to-end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mineru findsupports limiting filename-search results but does not expose an offset, so callers cannot page through matching files consistently. This PR adds offset pagination tofindand aligns its public interface with content search.Closes #5301.
Modification
--offsetto themineru findCLI and forward it through the sync/async interfaces, HTTP client, server, and search service.file_idtie-breaker to filename FTS ordering so repeated page requests remain stable.BC-breaking (Optional)
No. The new
offsetargument defaults to0, preserving existing behavior.Use cases (Optional)
mineru find "report" --ext pdf --limit 20 --offset 20 --jsonThis returns the second page of PDF filename matches after filtering.
Testing
git diff --checkpassed.Checklist
Before PR:
After PR: