fix: support filename prefix search - #5366
Open
lylelllll wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mineru find benchcurrently misses filenames such asbench1.pdf, even though the explicit wildcard formbench*works. This makes the default filename search behavior surprising and is the issue reported in #5281.Modification
*.BC-breaking (Optional)
No. Filename lookup becomes more permissive for the final query token; public Python APIs, content search, indexing, and storage are unchanged.
Testing
.venv/bin/python -m pytest -q -o addopts='' tests/unittest/test_doclib_cache_semantics.py tests/unittest/test_cli_next_command_design.py(307 passed)uvx ruff check mineru/doclib/core/fts.pyuvx ruff check --ignore ANN001,E501 tests/unittest/test_doclib_cache_semantics.pyModel/GPU parsing E2E tests were not run because this change is isolated to SQLite FTS filename query construction.
Checklist
Before PR:
After PR:
Fixes #5281