-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: usage of a deprecated Node.js version
in CI
#687
Open
hamirmahal
wants to merge
5
commits into
opendatalab:dev
Choose a base branch
from
hamirmahal:fix/usage-of-a-deprecated-nodejs-version-in-update-base-yml
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: usage of a deprecated Node.js version
in CI
#687
hamirmahal
wants to merge
5
commits into
opendatalab:dev
from
hamirmahal:fix/usage-of-a-deprecated-nodejs-version-in-update-base-yml
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solve uncorrect pair relation of table and caption opendatalab#590
…_footnote_relation fix: 1. resolve uncorrect pair relation of figure and footnote, 2. resolve uncorrect pair relation of table and caption opendatalab#590
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
hamirmahal
commented
Oct 5, 2024
echo "start test" | ||
|
||
- name: update-base | ||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the latest major version at the time of this writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #686.
Motivation
.github/workflows/update_base.yml
usesa deprecated Node.js version
.Modification
.github/workflows/update_base.yml
no longer usesa deprecated Node.js version
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
No.
Checklist
Before PR:
After PR: