Fix shifted bounding boxes calculation #80
Conversation
LonelyMidoriya
requested review from
MaximPlusov,
hnc-hyunheejo and
hnc-leebd
as code owners
|
@codex review |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| BoundingBox box = DocumentProcessor.getPageBoundingBox(boundingBox.getPageNumber()); | ||
| if (box != null) { | ||
| boundingBox.move(box.getLeftX(), box.getBottomY()); | ||
| } |
There was a problem hiding this comment.
The new translation in draw moves the passed BoundingBox directly. These bounding boxes live in the contents collection, which is reused after PDF generation to emit JSON/HTML/text in DocumentProcessor.processFile. As a result, calling updatePDF now permanently shifts every bounding box and the coordinates serialized later depend on whether PDF generation ran beforehand. The filtering code in the same commit avoids this by translating a copy. Consider shifting a temporary copy for annotation placement instead of mutating the shared object.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
java/opendataloader-pdf-core/src/main/java/org/opendataloader/pdf/pdf/PDFWriter.java
Show resolved
Hide resolved
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
Checklist: