feat: bulk approve for lcr #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10997
branch
from
a374d8c to
2b4e3d4
Compare
Comment on lines
75
to
76
| raise Exception(f"Consistency Error: Missing assignment for approved request {request.uuid}") | ||
| approved_requests_map[request.uuid] = { |
There was a problem hiding this comment.
To keep the exceptions consistent, let's raise SubisidyAccessPolicyRequestApprovalError here.
| return valid_requests, failed_requests | ||
|
|
||
|
|
||
| def can_allocate_all(self, learner_credit_requests): |
There was a problem hiding this comment.
I think instead of creating a new method, let's just move this code into can_approve() or assignment_request_can_allocate if we are relying on any content assignments functionality.
Comment on lines
+1990
to
+1995
| # Verifies that the price on each LearnerCreditRequest is within the | ||
| # acceptable tolerance range of its canonical price. | ||
| valid_requests, failed_price_requests = self.validate_learner_credit_requests_allocation_prices( | ||
| requests_in_catalog, all_metadata | ||
| ) |
There was a problem hiding this comment.
Can we use validate_requested_allocation_price for handling this?
|
|
||
| # If the request has a valid lms_user_id, also check for a match on that. | ||
| if request.user.lms_user_id: | ||
| sub_query |= Q(lms_user_id=request.user.lms_user_id, content_key=request.course_id) |
There was a problem hiding this comment.
this is not needed as the a learner submitting a request will always be a valid user.
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10997
branch
8 times, most recently
from
5a3cecb to
a19f4f9
Compare
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10997
branch
3 times, most recently
from
f6aa027 to
2414502
Compare
ahmad-hassan-dev
force-pushed
the
ahmad-hassan-dev/ENT-10997
branch
from
2414502 to
be4fc6b
Compare
sameenfatima78
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a description of your changes here.
Jira:
ENT-XXXX
Merge checklist:
./manage.py makemigrationshas been runPost merge: