feat: terminate stuck paid checkout intent #913
Conversation
| self.stdout.write( | ||
| f'{mode_label}Checking for CheckoutIntent records stuck in paid state ' | ||
| f'for more than {threshold_seconds} seconds...' | ||
| ) | ||
| logger.info( | ||
| '%sStarting mark_stalled_checkout_intents command with threshold=%s seconds', | ||
| mode_label, | ||
| threshold_seconds, | ||
| ) |
There was a problem hiding this comment.
I think we can remove one of these duplicative messages throughout the code. I'm pretty sure logger already goes to stdout, and the stdout messages are not already designed to be machine-readable, so I think we can just remove the stdout.write() lines and keep the logger.info lines
Functionally, you're using stdout.write() as a logger, but it's weaker than logger because it lacks timestamps and other useful metadata.
| self.stdout.write( | ||
| self.style.SUCCESS( | ||
| f'{mode_label}Command completed successfully' | ||
| ) | ||
| ) |
There was a problem hiding this comment.
IMO, this is the only self.stdout.write() I'd keep, to leverage the success style.
| threshold_seconds, | ||
| ) | ||
|
|
||
| if dry_run: |
There was a problem hiding this comment.
This implementation of a dry run isn't quite appropriate because it replaces too much business logic. A better approach would be to pass a dry run flag into a lower level function and implement dry run within.
| updated_count, updated_uuids = CheckoutIntent.mark_stalled_fulfillment_intents( | ||
| stalled_threshold_seconds=threshold_seconds | ||
| ) |
There was a problem hiding this comment.
This is probably where dry_run needs to be passed.
2 participants
Description:
Add a description of your changes here.
Jira:
ENT-11059 & ENT-11123
Merge checklist:
./manage.py makemigrationshas been runPost merge: