-
Notifications
You must be signed in to change notification settings - Fork 16
feat: upcoming invoice amount due #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @iloveagent57! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
2e09234 to
9e19fa6
Compare
f7e9645 to
91811fe
Compare
enterprise_access/apps/customer_billing/migrations/0018_merge_20251105_0545.py
Outdated
Show resolved
Hide resolved
pwnage101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Aside from the comments above, LGTM.
| https://docs.stripe.com/changelog/basil/2025-03-31/invoice-preview-api-deprecations | ||
| https://docs.stripe.com/api/invoices/create_preview?architecture-style=resources | ||
| """ | ||
| return stripe.Invoice.create_preview( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL create_preview() is a replacement for the deprecated upcoming().
0a216aa to
6a42741
Compare
926fa69 to
9e1d56a
Compare
9e1d56a to
e934b9f
Compare
brobro10000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment about code cleanup to avoid duplicative code.
| User = get_user_model() | ||
|
|
||
|
|
||
| class AttrDict(dict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this class also exists within the following directory.
enterprise_access/apps/customer_billing/tests/test_stripe_event_handlers.py
Might be worth doing a bit of cleanup and generalizing as a common test helper function to avoid duplicative code.
brobro10000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to unblock. I'd wait for either @iloveagent57 or @pwnage101 for a final review before merging.
7e58543 to
e2f536b
Compare
http://localhost:18270/api/v1/stripe-event-summary/first_upcoming_invoice_amount_due/?subscription_plan_uuid=aaaabbbb-db33-455d-80ca-0153dd1e94faMerge checklist:
./manage.py makemigrationshas been runPost merge: