Skip to content

Conversation

@iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Oct 31, 2025

http://localhost:18270/api/v1/stripe-event-summary/first_upcoming_invoice_amount_due/?subscription_plan_uuid=aaaabbbb-db33-455d-80ca-0153dd1e94fa
Screenshot 2025-11-06 at 1 30 24 AM

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 31, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 31, 2025

Thanks for the pull request, @iloveagent57!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 31, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Nov 4, 2025
@kiram15 kiram15 force-pushed the aed/upcoming-invoice branch from f7e9645 to 91811fe Compare November 5, 2025 06:40
@kiram15 kiram15 marked this pull request as ready for review November 5, 2025 06:41
Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Aside from the comments above, LGTM.

https://docs.stripe.com/changelog/basil/2025-03-31/invoice-preview-api-deprecations
https://docs.stripe.com/api/invoices/create_preview?architecture-style=resources
"""
return stripe.Invoice.create_preview(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL create_preview() is a replacement for the deprecated upcoming().

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Nov 5, 2025
@kiram15 kiram15 force-pushed the aed/upcoming-invoice branch from 0a216aa to 6a42741 Compare November 5, 2025 22:58
@kiram15 kiram15 force-pushed the aed/upcoming-invoice branch from 926fa69 to 9e1d56a Compare November 6, 2025 09:11
@kiram15 kiram15 force-pushed the aed/upcoming-invoice branch from 9e1d56a to e934b9f Compare November 6, 2025 09:25
Copy link
Member

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment about code cleanup to avoid duplicative code.

User = get_user_model()


class AttrDict(dict):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this class also exists within the following directory.
enterprise_access/apps/customer_billing/tests/test_stripe_event_handlers.py

Might be worth doing a bit of cleanup and generalizing as a common test helper function to avoid duplicative code.

Copy link
Member

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock. I'd wait for either @iloveagent57 or @pwnage101 for a final review before merging.

@kiram15 kiram15 force-pushed the aed/upcoming-invoice branch from 7e58543 to e2f536b Compare November 6, 2025 17:13
@kiram15 kiram15 merged commit f8735eb into main Nov 6, 2025
4 checks passed
@kiram15 kiram15 deleted the aed/upcoming-invoice branch November 6, 2025 17:47
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants