refactor: migrate to frontend-base #1512
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: refactors the MFE for frontend-base.
8 tasks
8 tasks
arbrandes
commented
Jun 26, 2025
| it('renders Image layout when ENABLE_IMAGE_LAYOUT configuration is enabled', () => { | ||
| mergeConfig({ | ||
| ENABLE_IMAGE_LAYOUT: true, | ||
| mergeSiteConfig({ |
There was a problem hiding this comment.
Suggested change
| mergeSiteConfig({ | |
| mergeAppConfig(testAppId, { |
arbrandes
commented
Jun 26, 2025
src/routes.jsx
Outdated
Comment on lines
60
to
65
| { | ||
| path: '*', | ||
| element: ( | ||
| <Navigate replace to={PAGE_NOT_FOUND} /> | ||
| ), | ||
| } |
There was a problem hiding this comment.
Probably not a good idea having an app with a catch-all. This should be handled by the shell. (Thanks @bradenmacdonald for catching this.)
The only purpose of the included index.html is to serve the dev environment, so modify it to make that clear.
Apps should avoid having a catch-all route, instead relying on the shell to provide it.
Update package.json for publication as a "buildless" library. (Also upgrade openedx-atlas.)
feat: Prepare for publication to NPM
Now we have a way to discover app URLs dynamically; do so for the (default) redirect on login.
Bump frontend-base to alpha.4 to fix a bug with the route role redirection mechanism.
Bump frontend-base to avoid the inotify handle resource starvation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to the parent issue for a full description.
In short, this refactors the codebase for frontend-base support. There are several breaking changes. It is a long-lived feature branch, and as such, should not be rebased or squashed until time comes for it to either merge to master or become master.