feat: add course import page [FC-0112] #2580

rpenido · 2025-10-28T19:49:41Z

Description

This PR adds the Library Import Home, which lists course migrations to the library

Which user roles will this change impact?
"Course Author" and "Developer"

Supporting information

Related to: Import Home Page #2523
Depends on: feat: add library migration list endpoint [FC-0112] edx-platform#37567

Testing instructions

Open the Library Import Home (Tools > Import from inside the library) for a library that has not received any migrated courses
Check the empty state
Migrate some courses to the library, selecting a target collection
Open the Library Import Home and check the migration
- Clicking on the title should navigate to the course
- Clicking on the collection name should navigate to the collection

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

Any new files are using TypeScript (.ts, .tsx).
Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
All new i18n messages in messages.ts files have a description for translators to use.
Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

Private ref: FAL-4265

openedx-webhooks · 2025-10-28T19:49:45Z

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-10-28T19:59:58Z

Codecov Report

❌ Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.83%. Comparing base (436ac31) to head (6b3827b).
⚠️ Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
src/library-authoring/data/api.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2580    +/-   ##
========================================
  Coverage   94.82%   94.83%            
========================================
  Files        1226     1231     +5     
  Lines       27557    27627    +70     
  Branches     6043     6221   +178     
========================================
+ Hits        26131    26199    +68     
- Misses       1368     1370     +2     
  Partials       58       58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/library-authoring/data/apiHooks.ts

src/library-authoring/import-course/CourseImportHomePage.test.tsx

src/library-authoring/import-course/CourseImportHomePage.tsx

src/library-authoring/import-course/MigratedCourseCard.test.tsx

navinkarkera · 2025-11-06T04:44:19Z

@rpenido The right chevron is missing here.

Also, the collection link color and underline is not matching with designs.

navinkarkera

@rpenido Nice work! This looks good. Left some suggestions.

navinkarkera · 2025-11-06T05:05:00Z

src/library-authoring/data/api.ts

  await getAuthenticatedHttpClient().post(getLibraryContainerPublishApiUrl(containerId));
 }
+
+export interface CourseMigration {


NIT: rename to indicate import instead of migration

navinkarkera · 2025-11-06T05:05:22Z

src/library-authoring/data/apiHooks.ts

+  migrations: (libraryId: string) => [
+    ...libraryAuthoringQueryKeys.contentLibrary(libraryId),
+    'migrations',


Same here. Rename to import.

navinkarkera · 2025-11-06T05:07:22Z

src/library-authoring/import-course/CourseImportHomePage.tsx

+          title={libraryData.title}
+          org={libraryData.org}
+          contextId={libraryId}
+          isLibrary


Pass readOnly from library context here.

Suggested change

isLibrary

isLibrary

readOnly={readOnly}

Thanks! Fixed here: f17820b

navinkarkera · 2025-11-06T05:14:42Z

src/library-authoring/import-course/index.scss

+.course-migration-help {
+  z-index: 1000; // same as header
+  flex: 350px 0 0;
+  position: sticky;
+  top: 0;
+  right: 0;
+  height: 100vh;
+  overflow-y: auto;
+
+  hr {
+    width: 100%;
+  }
+}


We can remove this completely. It unnecessarily adds vertical scroll

I was trying to avoid the same issue from here: #2200 (comment)

Removed: cab000a

navinkarkera · 2025-11-06T05:14:54Z

src/library-authoring/import-course/HelpSidebar.tsx

+import messages from './messages';
+
+export const HelpSidebar = () => (
+  <div className="course-migration-help pt-3 border-left">


Suggested change

<div className="course-migration-help pt-3 border-left">

<div className="pt-3 border-left">

Fixed cab000a

navinkarkera · 2025-11-06T05:15:06Z

src/library-authoring/import-course/HelpSidebar.tsx

+          />
+        </span>
+      </Stack>
+      <hr />


Suggested change

<hr />

<hr className="w-100" />

Fixed: cab000a

navinkarkera · 2025-11-06T05:59:08Z

src/library-authoring/import-course/CourseImportHomePage.tsx

+            size: undefined,
+          }}
+        />
+        <Container className="px-0 mt-4 mb-5 library-authoring-page">


Suggested change

<Container className="px-0 mt-4 mb-5 library-authoring-page">

<Container className="mt-4 mb-5">

px-0 adds unnecessary horizontal scroll and library-authoring-page has no effect

Thanks! Fixed: ab24e7c

rpenido · 2025-11-06T17:23:32Z

@rpenido The right chevron is missing here.

I missed that! Thanks!

Also, the collection link color and underline is not matching with designs.

I was trying to stick to our default Paragon design (https://paragon-openedx.netlify.app/components/button/#when-to-use-the-inline-size) and prevent custom styles.

Both fixed here: 73948ab

ChrisChV

The code looks good! @rpenido Thanks! 👍 I will merge it after fixing the broken lint and after the review of @navinkarkera

navinkarkera

@rpenido Great work 👍

I tested this: (Played around with import home page)
I read through the code
I checked for accessibility issues
Includes documentation

navinkarkera · 2025-11-07T04:18:48Z

src/library-authoring/import-course/ImportedCourseCard.tsx

+          <Link
+            to={`/course/${courseImport.source.key}`}
+            aria-label={intl.formatMessage(messages.courseImportNavigateAlt)}
+            className="text-primary-500"
+          >
+            <Icon src={ArrowForwardIos} />
+          </Link>


This can be updated as part of #2526. The link should take user to import details page and I think the whole card should be clickable.

src/library-authoring/import-course/ImportedCourseCard.tsx

Co-authored-by: Navin Karkera <[email protected]>

ChrisChV · 2025-11-07T16:07:38Z

@rpenido is it ready to be merged?

rpenido · 2025-11-07T16:09:04Z

@rpenido is it ready to be merged?

Yeah!

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 28, 2025

openedx-webhooks added this to Contributions Oct 28, 2025

github-project-automation bot moved this to Needs Triage in Contributions Oct 28, 2025

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 29, 2025

rpenido force-pushed the rpenido/FAL-4265/import-home branch 7 times, most recently from bb4eff0 to 9230c0e Compare November 4, 2025 22:06

feat: add course import page

ca3c068

rpenido force-pushed the rpenido/FAL-4265/import-home branch from 9230c0e to ca3c068 Compare November 4, 2025 22:38

rpenido changed the title ~~feat: add course import page~~ feat: add course import page [FC-0112] Nov 4, 2025

rpenido marked this pull request as ready for review November 5, 2025 17:56

rpenido mentioned this pull request Nov 5, 2025

feat: add library migration list endpoint [FC-0112] openedx/edx-platform#37567

Merged

ChrisChV requested changes Nov 6, 2025

View reviewed changes

navinkarkera suggested changes Nov 6, 2025

View reviewed changes

rpenido added 9 commits November 6, 2025 10:40

fix: change loading placeholder

868084d

refactor: renaming migration > import

9a97f25

test: move initializeMocks to beforeEach

262754c

test: replace query.. by get..

42a31b0

test: add await to userEvent.click and remove waitFor

85834d1

fix: pass readOnly flag to Header

f17820b

fix: add intl to Previous Imports title

b843763

test: removing unused import

0878749

fix: remove custom css for help sidebar

cab000a

fix: remove unused class and padding

ab24e7c

rpenido force-pushed the rpenido/FAL-4265/import-home branch from e11f76f to ab24e7c Compare November 6, 2025 16:54

fix: style on ImportedCourseCard

73948ab

ChrisChV approved these changes Nov 6, 2025

View reviewed changes

fix: task_status string for In Progress

fc79cb1

rpenido force-pushed the rpenido/FAL-4265/import-home branch from fb1eded to fc79cb1 Compare November 6, 2025 21:16

navinkarkera approved these changes Nov 7, 2025

View reviewed changes

fix: open course in new page

6b3827b

Co-authored-by: Navin Karkera <[email protected]>

ChrisChV merged commit 6d619b9 into openedx:master Nov 7, 2025
7 checks passed

github-project-automation bot moved this from Waiting on Author to Done in Contributions Nov 7, 2025

ChrisChV deleted the rpenido/FAL-4265/import-home branch November 7, 2025 21:32

	<div className="course-migration-help pt-3 border-left">
	<div className="pt-3 border-left">

	<Container className="px-0 mt-4 mb-5 library-authoring-page">
	<Container className="mt-4 mb-5">

feat: add course import page [FC-0112] #2580

feat: add course import page [FC-0112] #2580

Conversation

rpenido commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Best Practices Checklist

Uh oh!

openedx-webhooks commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

navinkarkera commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

navinkarkera left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpenido Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpenido Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpenido Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpenido Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpenido commented Nov 6, 2025

Uh oh!

ChrisChV left a comment

Choose a reason for hiding this comment

Uh oh!

navinkarkera left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChrisChV commented Nov 7, 2025

Uh oh!

rpenido commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

rpenido commented Oct 28, 2025 •

edited

Loading

openedx-webhooks commented Oct 28, 2025 •

edited

Loading

codecov bot commented Oct 28, 2025 •

edited

Loading

navinkarkera commented Nov 6, 2025 •

edited

Loading

rpenido Nov 6, 2025 •

edited

Loading

rpenido Nov 6, 2025 •

edited

Loading

rpenido Nov 6, 2025 •

edited

Loading

rpenido Nov 6, 2025 •

edited

Loading