-
Notifications
You must be signed in to change notification settings - Fork 165
chore: don't name unused errors in catch expressions #2591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: don't name unused errors in catch expressions #2591
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2591 +/- ##
==========================================
- Coverage 94.81% 94.80% -0.01%
==========================================
Files 1225 1225
Lines 27481 27483 +2
Branches 6187 6026 -161
==========================================
Hits 26056 26056
- Misses 1367 1369 +2
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisChV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍 It's missing to fix the coverage to merge it
- I read through the code and considered the security, stability and performance implications of the changes.
|
Thanks! And I can merge the PR anyways. This PR is not actually changing the coverage; that's just a codecov issue. |
Found using oxlint. This removes unused error variables in
catch()expressions.Part of #2559
Private ref MNG-4763