chore: fix no-base-to-string #2597
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a few places on in the code we are calling
.toString()on an object with a type likeReadableStream<Uint8Array<ArrayBuffer>> | BodyInit | null | undefined. Because this could be an object, oxlint is warning us against using.toString()which will just return a string like[object Object]or[object ArrayBuffer]. However, it turns out that in each case the type is already astringso we don't need to be calling.toString()at all.Rule documentation:
Part of #2559
Private ref MNG-4763