-
Notifications
You must be signed in to change notification settings - Fork 179
Deprecate ENABLE_GRADING_METHOD_IN_PROBLEMS & Add Grading Method view #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ENABLE_GRADING_METHOD_IN_PROBLEMS & Add Grading Method view #2795
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2795 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 1274 1274
Lines 29835 29850 +15
Branches 6759 6762 +3
=======================================
+ Hits 28386 28401 +15
Misses 1377 1377
Partials 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @irtazaakram, the PR looks very good. Thank you very much for continuing the work! I tested it together with the edx-platform PR, and everything seems to be working correctly. I only have a question. Should the default grading method (Last score) be preselected when the problem component is created? Right now it looks like this:
|
|
Thank you for looking into this, @BryanttV. Yes, that makes sense to me. I’ve updated the implementation so that the default grading method (“Last score”) is preselected when the problem component is created. |
BryanttV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! I tested it again, and it works very well. On my side, I’m giving my approval. Thanks again!

Description
This pull request does two things:
ENABLE_GRADING_METHOD_IN_PROBLEMStoggleBackground / Rationale:
[frontend-lib-content-components](https://github.com/openedx-unsupported/frontend-lib-content-components), but that library has since been deprecated.Impact on user roles:
UI Changes:
Before:

After:

Supporting information
frontend-lib-content-componentsPR #430Testing instructions
openedx-unsupported/frontend-lib-content-components#430 (comment)
openedx-unsupported/frontend-lib-content-components#430 (comment)
Other information
openedx/openedx-platform#37811
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'