Skip to content

Conversation

@irtazaakram
Copy link
Member

Description

This pull request does two things:

  1. Deprecates the ENABLE_GRADING_METHOD_IN_PROBLEMS toggle
  2. Adds the missing Grading Method view

Background / Rationale:

Impact on user roles:

  • Course Authors / Studio users: Will now see the grading method displayed in problem block settings and can change it.
  • Developers: Removes reliance on the deprecated feature toggle.

UI Changes:

Before:
Screenshot 2026-01-07 at 2 59 41 PM

After:
Screenshot 2026-01-07 at 3 00 36 PM

Supporting information

Testing instructions

openedx-unsupported/frontend-lib-content-components#430 (comment)
openedx-unsupported/frontend-lib-content-components#430 (comment)

Other information

openedx/openedx-platform#37811

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@irtazaakram irtazaakram moved this to 👀 In review in Aximprovements Team Jan 7, 2026
@irtazaakram irtazaakram moved this from 👀 In review to 🏗 In progress in Aximprovements Team Jan 7, 2026
@irtazaakram irtazaakram self-assigned this Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (5d97a98) to head (6efdea2).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2795   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files        1274     1274           
  Lines       29835    29850   +15     
  Branches     6759     6762    +3     
=======================================
+ Hits        28386    28401   +15     
  Misses       1377     1377           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@irtazaakram irtazaakram moved this from 🏗 In progress to 👀 In review in Aximprovements Team Jan 9, 2026
@BryanttV BryanttV self-requested a review January 15, 2026 17:46
@BryanttV
Copy link
Contributor

BryanttV commented Jan 15, 2026

Hi @irtazaakram, the PR looks very good. Thank you very much for continuing the work! I tested it together with the edx-platform PR, and everything seems to be working correctly.

I only have a question. Should the default grading method (Last score) be preselected when the problem component is created? Right now it looks like this:

image

@irtazaakram irtazaakram moved this from 👀 In review to 🏗 In progress in Aximprovements Team Jan 20, 2026
@irtazaakram
Copy link
Member Author

Thank you for looking into this, @BryanttV. Yes, that makes sense to me. I’ve updated the implementation so that the default grading method (“Last score”) is preselected when the problem component is created.

@irtazaakram irtazaakram moved this from 🏗 In progress to 👀 In review in Aximprovements Team Jan 20, 2026
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I tested it again, and it works very well. On my side, I’m giving my approval. Thanks again!

@irtazaakram irtazaakram marked this pull request as ready for review January 28, 2026 08:24
@feanil feanil merged commit 05de984 into openedx:master Jan 28, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Aximprovements Team Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants