feat: add notification tray status to session storage #1823

filippovskii09 · 2025-11-10T12:40:49Z

Description

Fixed logic for saving notification tray status in session storage

Testing instructions

Steps to reproduce:

Create a new course.
Go to any unit
Click on Notification Icon Button
You see Notification Tray
Reload page and Notification Tray will not close

Before:

2025-11-10.14.44.37.mov

After:

2025-11-10.14.42.41.mov

openedx-webhooks · 2025-11-10T12:40:54Z

Thanks for the pull request, @filippovskii09!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-11-10T12:45:27Z

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.19%. Comparing base (d0a8778) to head (97e27a3).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
...bar/sidebars/notifications/NotificationTrigger.jsx	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
+ Coverage   90.86%   91.19%   +0.33%     
==========================================
  Files         348      348              
  Lines        5814     5817       +3     
  Branches     1341     1336       -5     
==========================================
+ Hits         5283     5305      +22     
+ Misses        514      495      -19     
  Partials       17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

open-craft-grove · 2025-11-10T12:51:50Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-11-10T16:58:34Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

itsjeyd · 2025-11-20T07:23:07Z

Hi @filippovskii09, thank you for this contribution! Since it's a user-facing change, it will need product approval before it can be merged.

Please choose your product contribution type and follow the corresponding instructions to get the product review process started.

open-craft-grove · 2025-11-20T13:59:04Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

PKulkoRaccoonGang

Thanks for this PR! I left a few minor comments related to the code. However, the main issue I found during testing is that on smaller screens, when the sidebar content expands to cover the whole window, there’s no way to close it.

Screen.Recording.2025-11-22.at.13.26.04.mov

PKulkoRaccoonGang · 2025-11-22T11:19:04Z

src/courseware/course/sidebar/SidebarContextProvider.jsx

  }, [courseId]);

  const toggleSidebar = useCallback((sidebarId) => {
-    // Switch to new sidebar or hide the current sidebar


Can we leave this comment?

PKulkoRaccoonGang · 2025-11-22T11:28:09Z

src/courseware/course/sidebar/sidebars/notifications/NotificationTrigger.test.jsx

Please check the comments in this file. Are all of them really necessary?

PKulkoRaccoonGang · 2025-11-22T11:29:22Z

src/courseware/course/sidebar/SidebarContextProvider.test.jsx

@@ -0,0 +1,199 @@
+import { useContext } from 'react';
+import { render, screen } from '@testing-library/react';


Can we import this from setupTest?

open-craft-grove · 2025-11-26T13:52:06Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

filippovskii09 · 2025-11-27T10:55:22Z

Thanks for this PR! I left a few minor comments related to the code. However, the main issue I found during testing is that on smaller screens, when the sidebar content expands to cover the whole window, there’s no way to close it.

Screen.Recording.2025-11-22.at.13.26.04.mov

issue has been fixed. thanks!

PKulkoRaccoonGang · 2025-11-28T08:52:05Z

webpack.dev-tutor.config.js

Let’s remove this file from the PR and add it to .gitignore instead.

open-craft-grove · 2025-11-28T12:24:32Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

feat: add notification tray status to session storage

0606bca

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 10, 2025

openedx-webhooks added this to Contributions Nov 10, 2025

github-project-automation bot moved this to Needs Triage in Contributions Nov 10, 2025

filippovskii09 self-assigned this Nov 10, 2025

filippovskii09 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 10, 2025

itsjeyd added the product review PR requires product review before merging label Nov 20, 2025

itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Nov 20, 2025

fix: fix test and upgrade coverage

aa55953

filippovskii09 requested a review from PKulkoRaccoonGang November 20, 2025 13:03

PKulkoRaccoonGang suggested changes Nov 22, 2025

View reviewed changes

PKulkoRaccoonGang mentioned this pull request Nov 22, 2025

feat: improved accessibility of notification tray #1817

Draft

fix: fix bug and remove extra code

281a5bc

filippovskii09 requested a review from PKulkoRaccoonGang November 27, 2025 10:55

PKulkoRaccoonGang reviewed Nov 28, 2025

View reviewed changes

PKulkoRaccoonGang approved these changes Nov 28, 2025

View reviewed changes

fix: remove extra file and add him to gitignore

97e27a3

		@@ -0,0 +1,199 @@
		import { useContext } from 'react';
		import { render, screen } from '@testing-library/react';

feat: add notification tray status to session storage #1823

Are you sure you want to change the base?

feat: add notification tray status to session storage #1823

Conversation

filippovskii09 commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Steps to reproduce:

Uh oh!

openedx-webhooks commented Nov 10, 2025

Uh oh!

codecov bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

open-craft-grove commented Nov 10, 2025

Uh oh!

open-craft-grove commented Nov 10, 2025

Uh oh!

itsjeyd commented Nov 20, 2025

Uh oh!

open-craft-grove commented Nov 20, 2025

Uh oh!

PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Nov 26, 2025

Uh oh!

filippovskii09 commented Nov 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

filippovskii09 commented Nov 10, 2025 •

edited

Loading

codecov bot commented Nov 10, 2025 •

edited

Loading