feat: fixes after package-lock regen #1837
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @filippovskii09! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
filippovskii09
force-pushed
the
filippovskii/fix/deps-after-lock-regen
branch
from
46f8906 to
d6961e9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1837 +/- ##
==========================================
+ Coverage 91.13% 91.51% +0.37%
==========================================
Files 348 348
Lines 5801 5801
Branches 1330 1334 +4
==========================================
+ Hits 5287 5309 +22
+ Misses 497 475 -22
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
filippovskii09
force-pushed
the
filippovskii/fix/deps-after-lock-regen
branch
from
b48ac34 to
5acf4e4
Compare
| const actual = jest.requireActual('@openedx/paragon'); | ||
| const PropTypes = jest.requireActual('prop-types'); | ||
|
|
||
| const MockModalDialog = ({ children, isOpen, onClose }) => { |
There was a problem hiding this comment.
[important]: Is it possible to abandon the mock of this Paragon component?
| // Mock Intl.DateTimeFormat to return a consistent timezone across all environments | ||
| // This ensures that the browser_timezone query parameter matches the pact file | ||
| const OriginalDateTimeFormat = Intl.DateTimeFormat; | ||
| jest.spyOn(Intl, 'DateTimeFormat').mockImplementation((...args) => { |
There was a problem hiding this comment.
[question]: What exactly caused this change? Why did the tests work without it before?
4 participants
Description
This PR solved several issues that arose after deleting the
node_modulesfolder, thepackage-lock.jsonfile and running thenpm installcommand for install dependencies.List of problomes
How to test it
rm -rf node_modules package-lock.jsonnpm installornpm inpm run test,npm run build,npm run types,npm run lint