Open
Conversation
kdmccormick
reviewed
Mar 16, 2026
xmodule/video_block/video_block.py
Outdated
Comment on lines
+136
to
+139
| "_BuiltInVideoBlock is deprecated. Please use the extracted VideoBlock " | ||
| "from xblocks_contrib.video instead.", | ||
| DeprecationWarning, | ||
| stacklevel=2, |
Member
There was a problem hiding this comment.
This would be very noisy--we'd get a log entry every time the block was constructed, which could be multiple times per request. How about putting it at the top-level of the module, within if not settings.USE_EXTRACTED_VIDEO_BLOCK: ? That way it'll show once at startup.
I would also recommend mentioning the setting name and that it will be removed in Verawood. When an operator sees warnings in their logs, the questions they will have are "how can I fix this?" and "how long do I have to fix it?"
kdmccormick
approved these changes
Mar 17, 2026
Member
There was a problem hiding this comment.
Perfect 💯
I tested the warnings with built-in LTI and extracted HTML:
In [1]: from xblock.core import XBlock ; XBlock.load_class("lti")
2026-03-17 14:36:48,443 WARNING 39 [py.warnings] [user None] [ip None] warnings.py:112 - /opt/pyenv/versions/3.12.12/lib/python3.12/importlib/__init__.py:90: DeprecationWarning: The built-in `xmodule.lti_block` LTIBlock implementation is deprecated. To fix this warning, enable `USE_EXTRACTED_LTI_BLOCK` (set it to True) to use `xblocks_contrib.lti.LTIBlock` instead. Support for the built-in implementation, and the `USE_EXTRACTED_LTI_BLOCK` setting, will be removed in Willow.
return _bootstrap._gcd_import(name[level:], package, level)
Out[1]: xmodule.lti_block._BuiltInLTIBlock
In [2]: from xblock.core import XBlock ; XBlock.load_class("html")
Out[2]: xblocks_contrib.html.html.HtmlBlock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.