Switch to shared socket for calling buildkitd #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a shared socket for communication between Buildkit and the Pro Builder containers. This simplifies the deployment and removes the need to create and manage mTLS certificates. Chart changes: - `securityContext` for buildkit does not need to be set explicitly in the values.yaml file anymore. The appropriate default values are selected based on the value of the `buildkit.rootless` parameter. - BREAKING CHANGE - The `buildkit.image` parameter is now only used to set the image when `buildkit.rootless` is `false`. A new parameter `buildkitRootless.image` is used to set the image for rootless mode. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a shared socket for communication between Buildkit and the Pro Builder containers.
Chart changes:
securityContextfor buildkit does not need to be set explicitly in the values.yaml file anymore. The appropriate default values are selected based on the value of thebuildkit.rootlessparameter.BREAKING CHANGE: The
buildkit.imageparameter is now only used to set the image whenbuildkit.rootlessisfalse. A new parameterbuildkitRootless.imageis used to set the image for rootless mode.Why is this needed?
This simplifies the deployment and removes the need to create and manage mTLS certificates.
Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
Verified both the root and rootless mode are working on a local k3d cluster.
Verified the builder in rootless mode on an EKS cluster pushing to ECR with IRSA.
Types of changes
Checklist:
git commit -s