Support ndjson streams for function invocations #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welteki
force-pushed
the
ndjson
branch
2 times, most recently
from
3e36ae1 to
f327f5c
Compare
Additional fixes: - Support Accept headers with multiple Accept values - Accept header values should be mathced case insensitive. As stated in RFC 7321: https://datatracker.ietf.org/doc/html/rfc7231#section-3.1.1.1 Media Types are case-insensitive Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for streaming Newline Delimited JSON (NDJSON) from functions.
Additional fixes:
As stated in RFC 7321 Media Types are case insensitive
How has this been tested
A unit test was added.
Tested E2E with OpenFaaS Pro and a custom Go function that streams an NDJSON response.