🩹(api schema): add course query param to product retrieve route#231
Closed
rlecellier wants to merge 2 commits intomainfrom
Closed
🩹(api schema): add course query param to product retrieve route#231rlecellier wants to merge 2 commits intomainfrom
rlecellier wants to merge 2 commits intomainfrom
Conversation
rlecellier
force-pushed
the
rlecellier/generate_api_client
branch
2 times, most recently
from
7f58b6a to
3e65532
Compare
course is a mandatory query param for product.retrieve. we need it in order to correctly generate javascript api client.
rlecellier
force-pushed
the
rlecellier/generate_api_client
branch
from
3e65532 to
54d89b6
Compare
... for OrderViewSet Each viewset endpoints take and send differentes values. It's currently defined as Order for all ViewSet endpoints. Here we specify which data will be given in the request body and which data will be sent as response.
Collaborator
Author
|
dupliated here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
course is a mandatory query param for product.retrieve. we need it in order to correctly generate javascript api client.