Add time-resolved Numba fp x flux operator - #1703
Open
brendan-m-murphy wants to merge 6 commits into
Open
Conversation
5 tasks
brendan-m-murphy
marked this pull request as ready for review
August 7, 2026 15:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
fp_x_flux_time_resolved_numbaoperator inopenghg.analysesource,lat, andlonfor later basis projectionfp-x-fluxdependency extrafp-x-fluxextra in GitHub Actions so mypy and tests exercise the Numba pathMotivation and impact
Verification-games needs a source-resolved footprint-times-flux field without an automatic latitude/longitude reduction. Earlier
forward_model_testsapplied that reduction downstream, so it does not define a separate spatial-retention variant. The explicitfp_x_flux_time_resolved_numbaname makes this optimized implementation opt-in alongside the existing xarray paths while allowing callers to sum or project the spatial dimensions later.The native result is dimensionless mole fraction. The persistence helper converts it to ppm per unit source scaling.
Validation
uv sync --extra dev --extra fp-x-fluxpassed (Numba 0.66.0)uv lock --checkpassedgit diff --checkpassedChecklist
pyproject.tomlrecipes/meta.yamlupdated — not required because Numba is an optional extra and the recipe derives only the base runtime environment