-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mail] Fix documentation bug #16973
Merged
Merged
[mail] Fix documentation bug #16973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@rkoshak ping! |
@andrewfg - thanks! Now that we are at it: Perhaps you can also terminate statements by semicolons as good practice? |
J-N-K
approved these changes
Jul 1, 2024
@jlaur I don't understand what you mean. |
jlaur
reviewed
Jul 1, 2024
I never use semicolons in JS. |
jlaur
approved these changes
Jul 1, 2024
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jul 12, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Andrew Fiddian-Green <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mail] fix documentation
See this https://community.openhab.org/t/javascript-val-mail-binding-documentation/156928/4
Signed-off-by: Andrew Fiddian-Green [email protected]