Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mail] Fix documentation bug #16973

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[mail] Fix documentation bug #16973

merged 1 commit into from
Jul 1, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jul 1, 2024

[mail] fix documentation

See this https://community.openhab.org/t/javascript-val-mail-binding-documentation/156928/4

Signed-off-by: Andrew Fiddian-Green [email protected]

Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg added bug An unexpected problem or unintended behavior of an add-on documentation labels Jul 1, 2024
@andrewfg andrewfg self-assigned this Jul 1, 2024
@andrewfg andrewfg requested a review from J-N-K as a code owner July 1, 2024 10:54
@andrewfg
Copy link
Contributor Author

andrewfg commented Jul 1, 2024

@rkoshak ping!

@andrewfg andrewfg requested a review from a team July 1, 2024 10:55
@andrewfg andrewfg changed the title [mail] fix documenation [mail] Fix documenation bug Jul 1, 2024
@jlaur
Copy link
Contributor

jlaur commented Jul 1, 2024

@andrewfg - thanks! Now that we are at it: Perhaps you can also terminate statements by semicolons as good practice?

@jlaur jlaur removed the bug An unexpected problem or unintended behavior of an add-on label Jul 1, 2024
@lsiepel lsiepel changed the title [mail] Fix documenation bug [mail] Fix documentation bug Jul 1, 2024
@andrewfg
Copy link
Contributor Author

andrewfg commented Jul 1, 2024

also terminate statements by semicolons as good practice

@jlaur I don't understand what you mean.

@J-N-K
Copy link
Member

J-N-K commented Jul 1, 2024

I never use semicolons in JS.

@jlaur jlaur merged commit 0a7ed2b into openhab:main Jul 1, 2024
5 checks passed
@jlaur jlaur added this to the 4.2 milestone Jul 1, 2024
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jul 12, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg deleted the mail-fix-doc branch August 25, 2024 12:54
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Andrew Fiddian-Green <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants