[jsscripting] Synchronize context access in logger initialization #17496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid illegal multi-thread access Fixes openhab#17494. Signed-off-by: Florian Hotze <[email protected]>
maniac103
reviewed
Oct 2, 2024
...ng/src/main/java/org/openhab/automation/jsscripting/internal/DebuggingGraalScriptEngine.java
Outdated
Show resolved
Hide resolved
maniac103
reviewed
Oct 2, 2024
...ng/src/main/java/org/openhab/automation/jsscripting/internal/DebuggingGraalScriptEngine.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Hotze <[email protected]>
|
The user who reported this issue said he can't reproduce it reliably, so he is not really able to verify the fix in time. I have analysed the issue in the debugger and according to debugging what gets called when and if locking is active or not, this should fix the issue. I therefore mark this as ready for review. |
lsiepel
pushed a commit
that referenced
this pull request
Oct 4, 2024
…7496) * [jsscripting] Synchronize context access in logger initialisation to avoid illegal multi-thread access Fixes #17494. Signed-off-by: Florian Hotze <[email protected]>
lsiepel
added
the
patch
|
Done. |
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…enhab#17496) * [jsscripting] Synchronize context access in logger initialisation to avoid illegal multi-thread access Fixes openhab#17494. Signed-off-by: Florian Hotze <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…enhab#17496) * [jsscripting] Synchronize context access in logger initialisation to avoid illegal multi-thread access Fixes openhab#17494. Signed-off-by: Florian Hotze <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…enhab#17496) * [jsscripting] Synchronize context access in logger initialisation to avoid illegal multi-thread access Fixes openhab#17494. Signed-off-by: Florian Hotze <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to avoid illegal multi-thread access
Fixes #17494.