[mqtt.homeassistant] Document which channels a component might have #17618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moves JSON attributes channel to AbstractComponent, since _every_ component supports it now (so this commit adds it to the final few components that didn't have it). And renames the switch channel on a fan to `switch` instead of `fan`, matching how `light` works. Only for newStyleChannels. Signed-off-by: Cody Cutrer <[email protected]>
lsiepel
requested changes
Oct 25, 2024
...c/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/AbstractComponent.java
Show resolved
Hide resolved
lsiepel
added
the
enhancement
Co-authored-by: lsiepel <[email protected]> Signed-off-by: Cody Cutrer <[email protected]>
They get it from AbstractComponent now Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Cody Cutrer <[email protected]>
Recently merged to main Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Cody Cutrer <[email protected]>
Recently merged Signed-off-by: Cody Cutrer <[email protected]>
it's added differently than other components because it's a trigger channel Signed-off-by: Cody Cutrer <[email protected]>
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
…penhab#17618) * [mqtt.homeassistant] document which channels a component might have Signed-off-by: Cody Cutrer <[email protected]>
jlaur
changed the title
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
…penhab#17618) * [mqtt.homeassistant] document which channels a component might have Signed-off-by: Cody Cutrer <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…penhab#17618) * [mqtt.homeassistant] document which channels a component might have Signed-off-by: Cody Cutrer <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves JSON attributes channel to AbstractComponent, since every component supports it now (so this commit adds it to the final few components that didn't have it).
And renames the switch channel on a fan to
switchinstead offan, matching howlightworks. Only for newStyleChannels.