Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[airparif] New binding #17625

Merged
merged 18 commits into from
Feb 12, 2025
Merged

[airparif] New binding #17625

merged 18 commits into from
Feb 12, 2025

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Oct 24, 2024 •
edited
Loading

The AirParif binding provides data coming from Air Parif.
This service gives air quality and pollen information for Paris Area

@clinique clinique added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Oct 24, 2024
@clinique clinique self-assigned this Oct 24, 2024
@clinique clinique requested a review from a team as a code owner October 24, 2024 15:40
@clinique clinique removed the work in progress A PR that is not yet ready to be merged label Nov 18, 2024
@clinique clinique requested review from lolodomo and lsiepel November 20, 2024 16:38
@clinique
Copy link
Contributor Author

This is ready to review now. If someone has some spare time... :-)

lsiepel
lsiepel requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Reviewed all files. Don;t forget to run the i18n tool after all comments have been addressed. It already is in a good shape.

@clinique
Initial commit
1265419 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Progress done
4658292 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Remove doc file
272fb89 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Finalizing binding
dc1ac4d 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Added binding to pom.xml
3bd53b7 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
SAT solving
838816c 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Solving nullable
ec0bb2f 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Placeholder corrected
8fcac57 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Adding Air Quality index
9aa3255 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Cleaning resource files
58ef294 
Bulletproofed icon servlet

Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Activating discovery service
815de29 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Code cleansing
86458b1 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Written documentation and reviewed channels descriptions
02bf3c1 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
Code review corrections
080f7a5 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique
POM update
3dc97e9 
Signed-off-by: Gaël L'hopital <[email protected]>
@clinique clinique requested a review from lsiepel December 16, 2024 12:23
@clinique
Fix headers
da4c636 
Signed-off-by: clinique <[email protected]>
@clinique
Forgot to change the year
8e279a0 
Signed-off-by: clinique <[email protected]>
@lsiepel lsiepel merged commit ee9697b into openhab:main Feb 12, 2025
1 of 2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Feb 12, 2025
@lsiepel
Copy link
Contributor

lsiepel commented Feb 12, 2025

Thanks again. Now, you could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

@clinique clinique deleted the airparif branch February 13, 2025 11:44
@clinique
Copy link
Contributor Author

Done openhab/openhab-docs#2459

matgroe pushed a commit to matgroe/openhab-addons that referenced this pull request Feb 24, 2025
@clinique @matgroe
[airparif] New binding (openhab#17625)
95e93b5 
* Initial commit

Signed-off-by: Gaël L'hopital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn left review comments

@lsiepel lsiepel lsiepel approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo

Assignees

@clinique clinique

Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clinique @lsiepel @wborn