Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Fix missing links implementation #18274

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Feb 16, 2025

This change fixes the missing links implementation. It includes:

  • Ignore missing modem links when the modem monitor mode is on.
  • Allowing device with one component to have a component ID of 0 or 1 instead of being driven by the default link configuration.
  • Removing default link command support migrating the configure commands as hidden features.
  • Refactoring the device missing links console commands

This should be backported as the current implementation identifies false positives with unnecessary warning log statements, along with the addMissingLinks console command failing to add multiple modem missing links in a row requiring the command to be ran multiple times.

@jsetton jsetton added the bug An unexpected problem or unintended behavior of an add-on label Feb 16, 2025
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit f4338cc into openhab:main Feb 16, 2025
2 checks passed
@jlaur jlaur added this to the 5.0 milestone Feb 16, 2025
@jlaur
Copy link
Contributor

jlaur commented Feb 16, 2025

@jsetton - the commit cannot be cherry-picked into 4.3.x due to conflicts. In order for this to be backported to the next patch release, please provide a PR targeting 4.3.x directly with a clear note and reference to this PR.

@jsetton jsetton deleted the insteon-missing-links-fix branch February 17, 2025 00:09
@jsetton
Copy link
Contributor Author

jsetton commented Feb 17, 2025

please provide a PR targeting 4.3.x directly with a clear note and reference to this PR.

Done. Conflicts were related to #17958.

@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Feb 18, 2025
@lsiepel
Copy link
Contributor

lsiepel commented Feb 18, 2025

Patched by #18280

matgroe pushed a commit to matgroe/openhab-addons that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants