Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xmppclient] Host parameter should not be mandatory #18289

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[xmppclient] Host parameter should not be mandatory #18289

merged 1 commit into from
Feb 20, 2025

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 19, 2025

@lsiepel
Fix domain
b812030 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Feb 19, 2025
@lsiepel lsiepel added additional testing preferred The change works for the pull request author. A test from someone else is preferred though. and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Feb 19, 2025
@kaikreuzer kaikreuzer merged commit d3b3db3 into openhab:main Feb 20, 2025
2 checks passed
@kaikreuzer kaikreuzer added this to the 5.0 milestone Feb 20, 2025
@kaikreuzer kaikreuzer added the patch A PR that has been cherry-picked to a patch release branch label Feb 20, 2025
kaikreuzer pushed a commit to kaikreuzer/openhab-addons that referenced this pull request Feb 20, 2025
@lsiepel @kaikreuzer
Fix domain (openhab#18289)
7e6d5f3 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel deleted the xmpp-domain branch February 20, 2025 09:35
matgroe pushed a commit to matgroe/openhab-addons that referenced this pull request Feb 24, 2025
@lsiepel @matgroe
Fix domain (openhab#18289)
109bc0c 
Signed-off-by: Leo Siepel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@pavel-gololobov pavel-gololobov Awaiting requested review from pavel-gololobov pavel-gololobov is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[xmppclient] regression: host parameter required
2 participants
@lsiepel @kaikreuzer