-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wundergroundupdatereceiver] Fix parsing of dateutc query parameter #18415
[wundergroundupdatereceiver] Fix parsing of dateutc query parameter #18415
Conversation
Can you fix the DCO, when you click details, you can see the root cause. |
...g/openhab/binding/wundergroundupdatereceiver/internal/WundergroundUpdateReceiverHandler.java
Show resolved
Hide resolved
Hmm. Can you tell me were it gets it's expectation from? The email registered on github is the one I signed with, not the one it apparently expects. |
Not 100% sure. As it expects a anonimized GitHub adres, I guess somewhere in your settings ga you have enabled this to hide your real address. Your commits refer to the real address. So either cha ge the commit message or change the GH config. There are many tutorials on how to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM
Only waiting for DCO to pass.
Nope. This (and a backup gmail) is the only address ever registered with github. Something is not as it should be with this DCO check. Can someone with admin rights figure out what is going on? @kaikreuzer |
If you click "View details" on the failed DCO, you can see what is wrong:
|
The parameter is formatted with 1 digit hours, spewing warnings into the log, but otherwise having no effects as normal last XXX values are also recorded. Additionally a couple of unnoticed capitalisations were fixed Signed-off-by: Daniel Demus <[email protected]>
cf463fb
to
274f5ca
Compare
FWIW: For known contributors, we can also safely ignore the automatic DCO check, if it looks good to us! |
…18415) The parameter is formatted with 1 digit hours, spewing warnings into the log Signed-off-by: Daniel Demus <[email protected]>
The parameter is formatted with 1 digit hours, spewing warnings into the log, but otherwise having no effects, as normal last XXX values are also recorded.
Additionally a couple of unnoticed capitalisations were corrected.