Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wundergroundupdatereceiver] Fix parsing of dateutc query parameter #18415

Conversation

danieldemus
Copy link
Contributor

The parameter is formatted with 1 digit hours, spewing warnings into the log, but otherwise having no effects, as normal last XXX values are also recorded.

Additionally a couple of unnoticed capitalisations were corrected.

@lsiepel
Copy link
Contributor

lsiepel commented Mar 21, 2025

Can you fix the DCO, when you click details, you can see the root cause.

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Mar 21, 2025
@danieldemus
Copy link
Contributor Author

danieldemus commented Mar 21, 2025

Can you fix the DCO, when you click details, you can see the root cause.

Hmm. Can you tell me were it gets it's expectation from? The email registered on github is the one I signed with, not the one it apparently expects.
The current one is also the one I signed my original commits with, so I am stupified.

@lsiepel
Copy link
Contributor

lsiepel commented Mar 21, 2025

Can you fix the DCO, when you click details, you can see the root cause.

Hmm. Can you tell me were it gets it's expectation from? The email registered on github is the one I signed with, not the one it apparently expects. The current one is also the one I signed my original commits with, so I am stupified.

Not 100% sure. As it expects a anonimized GitHub adres, I guess somewhere in your settings ga you have enabled this to hide your real address.

Your commits refer to the real address. So either cha ge the commit message or change the GH config. There are many tutorials on how to.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

Only waiting for DCO to pass.

@danieldemus
Copy link
Contributor Author

Can you fix the DCO, when you click details, you can see the root cause.

Hmm. Can you tell me were it gets it's expectation from? The email registered on github is the one I signed with, not the one it apparently expects. The current one is also the one I signed my original commits with, so I am stupified.

Not 100% sure. As it expects a anonimized GitHub adres, I guess somewhere in your settings ga you have enabled this to hide your real address.

Your commits refer to the real address. So either cha ge the commit message or change the GH config. There are many tutorials on how to.

Nope. This (and a backup gmail) is the only address ever registered with github. Something is not as it should be with this DCO check. Can someone with admin rights figure out what is going on? @kaikreuzer

@jlaur
Copy link
Contributor

jlaur commented Mar 22, 2025

Nope. This (and a backup gmail) is the only address ever registered with github. Something is not as it should be with this DCO check. Can someone with admin rights figure out what is going on? @kaikreuzer

If you click "View details" on the failed DCO, you can see what is wrong:

Summary

Commit sha: cf463fb, Author: Daniel Demus, Committer: Daniel Demus; Expected "Daniel Demus [email protected]", but got "Daniel Demus [email protected]".

The parameter is formatted with 1 digit hours, spewing warnings into the log, but otherwise having no effects as normal last XXX values are also recorded.
Additionally a couple of unnoticed capitalisations were fixed

Signed-off-by: Daniel Demus <[email protected]>
@danieldemus danieldemus force-pushed the wundergroundupdatereceiver-unparsable-dateutc branch from cf463fb to 274f5ca Compare March 22, 2025 22:33
@kaikreuzer
Copy link
Member

FWIW: For known contributors, we can also safely ignore the automatic DCO check, if it looks good to us!

@lsiepel lsiepel merged commit 02b3daa into openhab:main Mar 23, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Mar 23, 2025
lsiepel pushed a commit that referenced this pull request Mar 25, 2025
…18415)

The parameter is formatted with 1 digit hours, spewing warnings into the log

Signed-off-by: Daniel Demus <[email protected]>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants