Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tado] Fix OAuthException on disabling and enabling the home Thing #18420

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Mar 19, 2025

Since #18354 now when you disable and re-enable the Home Thing, it requires a restart of OH before the Thing comes online again. This PR fixes that regression.

Fixes #18418

Signed-off-by: Andrew Fiddian-Green [email protected]

Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg added the regression Regression that happened during the development of a release. Not shown on final release notes. label Mar 19, 2025
@andrewfg andrewfg self-assigned this Mar 19, 2025
@andrewfg andrewfg requested a review from a team March 19, 2025 23:21
@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label Mar 19, 2025
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.
Do you need to perform additional tests confirmation ?

@andrewfg
Copy link
Contributor Author

Do you need to perform additional tests confirmation ?

No need. It is fully tested. (I should have done it before..)

@lsiepel lsiepel merged commit cfd9107 into openhab:main Mar 20, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Mar 20, 2025
@jlaur jlaur changed the title [tado] fix regression [tado] Fix OAuthException on disabling and enabling the home Thing Mar 20, 2025
magx2 pushed a commit to magx2/openhab2-addons that referenced this pull request Mar 21, 2025
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tado] Regression since #18354
2 participants