[whisperstt] Fix vad endless loop - #21453
Conversation
Signed-off-by: Holger Hees <holger.hees@gmail.com>
|
@florian-h05 maybe you know more about |
|
just a side note. Before this fix. My ESPHome device was left in a state where it was not useable anymore. Any new call to startDialog was not successful anymore. A binding restart was not successful anymore (device was offline in openhab). The only way to get it reactivated was a full restart of openhab. Regardless of this error, a pipeline should never end up in such a state. There should always be a way to reset things. I consider it unlikely that the issue lay with the device itself, given that the device continued running unchanged and was usable again after the openHAB restart. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/how-to-configure-a-esphome-voice-assistent-device/170100/18 |
florian-h05
left a comment
florian-h05
left a comment
There was a problem hiding this comment.
This change looks reasonable and good to me, thanks!
Signed-off-by: Holger Hees <holger.hees@gmail.com>
|
What about backporting that fix to 5.2.x branch ? |
|
Should be fine |
Signed-off-by: Holger Hees <holger.hees@gmail.com>
lolodomo
added
the
backported
|
Backported to branch 5.2.x |
5 participants
During testing my voice assistent device, VAD detected the whole time a voice, which results in a endless loop. RecognitionStopEvent was never triggered.
The problem related to the wrong VAD voice detection is not part of this pull request. This patch is just fixing the endless loop.
I guess that there is only a break missing.
I say "guess" and not "sure", because I am only just beginning to explore and understand the "voice" code. ;-)