[zwavejs] Ignore problematic websocket messages - #21458
Merged
Merged
Conversation
lsiepel
commented
Aug 22, 2026
lsiepel
commented
Contributor
- Ignore malformed or unsupported individual messages without incorrectly marking the active connection offline.
- Align the client fallback message size with the documented 16 MiB default.
- Adds tests to connection handling
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
approved these changes
Aug 23, 2026
| public String hostname = ""; | ||
| public int port = 3000; | ||
| public int maxMessageSize = 2097152; | ||
| public int maxMessageSize = DEFAULT_MAX_MESSAGE_SIZE; |
Contributor
There was a problem hiding this comment.
Verified that it corresponds to what's already here:
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Aug 28, 2026
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Contributor
|
What about backporting that fix to 5.2.x branch ? |
Contributor
Author
|
Yes please! |
lolodomo
pushed a commit
that referenced
this pull request
Aug 29, 2026
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Contributor
|
Backported |
lolodomo
added
the
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.