[chatgpt] Use max_completion_tokens for OpenAI requests - #21459
Merged
Conversation
Keep the existing maxTokens configuration key for backward compatibility while sending OpenAI-compatible chat completion payloads with max_completion_tokens. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
added
the
bug
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Aug 28, 2026
Keep the existing maxTokens configuration key for backward compatibility while sending OpenAI-compatible chat completion payloads with max_completion_tokens. Signed-off-by: Kai Kreuzer <kai@openhab.org>
Contributor
|
What about backporting that fix to 5.2.x branch ? |
Contributor
|
If possible (no merge conflicts), would be good to |
lolodomo
pushed a commit
that referenced
this pull request
Aug 29, 2026
Keep the existing maxTokens configuration key for backward compatibility while sending OpenAI-compatible chat completion payloads with max_completion_tokens. Signed-off-by: Kai Kreuzer <kai@openhab.org>
lolodomo
added
the
backported
Contributor
|
Backported to branch 5.2.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use more recent (specifically reasoning) models from OpenAI, I get this error in my log:
max_tokensparameter is deprecated and not even allowed anymore for reasoning models. Instead,max_completion_tokensshould be used.This PR is keeping the existing maxTokens configuration key for backward compatibility while sending OpenAI-compatible chat completion payloads with max_completion_tokens.