[roborock] Fix reset of consumables - #21498
Merged
Merged
Conversation
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets the Roborock binding’s “Reset Consumable” command flow, aiming to fix malformed RPC parameters and align consumable identifiers with what the Roborock protocol expects (per issue #21461).
Changes:
- Serialize the consumable-reset RPC parameter as valid JSON (string array) instead of constructing it via string concatenation.
- Update the consumable-reset channel option values in
thing-types.xmlto use underscore-based identifiers (protocol format).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| bundles/org.openhab.binding.roborock/src/main/java/org/openhab/binding/roborock/internal/RoborockVacuumHandler.java | Changes how the consumable reset RPC parameter is serialized before sending. |
| bundles/org.openhab.binding.roborock/src/main/resources/OH-INF/thing/thing-types.xml | Updates consumable-reset option values to protocol-correct underscore identifiers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
lsiepel
approved these changes
Aug 26, 2026
lsiepel
left a comment
lsiepel
left a comment
Contributor
There was a problem hiding this comment.
Thanks, LGTM
also for providing the test
psmedley
added a commit
to psmedley/openhab-addons
that referenced
this pull request
Aug 28, 2026
* Fix reset of consumables Signed-off-by: Paul Smedley <paul@smedley.id.au>
Contributor
|
What about backporting that fix to 5.2.x branch ? |
Contributor
Author
I agree it should be back ported. I'd hope it could be cherry-picked. |
lolodomo
pushed a commit
that referenced
this pull request
Aug 29, 2026
* Fix reset of consumables Signed-off-by: Paul Smedley <paul@smedley.id.au>
Contributor
|
Backported |
lolodomo
added
the
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21461