Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bambulab icon #2476

Merged
merged 5 commits into from
Mar 23, 2025
Merged

bambulab icon #2476

merged 5 commits into from
Mar 23, 2025

Conversation

magx2
Copy link
Contributor

@magx2 magx2 commented Mar 12, 2025

Icon for bambulab addon. Initial PR openhab/openhab-addons#18369

Copy link

netlify bot commented Mar 12, 2025

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 0701d22
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/67d20497354fdf0008ff21e6
😎 Deploy Preview https://deploy-preview-2476--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefan-hoehn
Copy link
Contributor

stefan-hoehn commented Mar 23, 2025

Do you mind providing a description? If it is for a binding, can you please provide a link to that binding?
Why do we have 5 commits for this single image?

@magx2
Copy link
Contributor Author

magx2 commented Mar 23, 2025

This is an icon for bambulab binding. There are 5 commits cause you are squashing commit during merge and my local main have commits for my previous bindings that are 'missing' in oh's main. If you gonna merge it (with squash) there will be no extra commits

@stefan-hoehn
Copy link
Contributor

The reason I am asking is to make sure that images are only provided after the binding has been merged. Therefore it helps if you provide a link to the PR that implements the binding, so I can check that. In your case I had to check if it is already available on my installation (it isn't), then I had to pull the latest version from the addons-repo for the the initial contribution for that binding which took me quite some time.
I eventually found it: openhab/openhab-addons#18369
Can you please add that to your description? Thanks.

@magx2
Copy link
Contributor Author

magx2 commented Mar 23, 2025

Ah ok, sorry I didn't understood you

@stefan-hoehn stefan-hoehn added this to the 5.0 milestone Mar 23, 2025
@stefan-hoehn stefan-hoehn merged commit fb4a95e into openhab:main Mar 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants