Ensure cached JsonElement instances are always cloned

openiddict · Oct 3, 2020 · 92c4848 · 92c4848
1 parent 66c0855
commit 92c4848
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 12 deletions.
diff --git a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkApplicationStore.cs b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkApplicationStore.cs
@@ -520,7 +520,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkAuthorizationStore.cs b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkAuthorizationStore.cs
@@ -460,7 +460,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkScopeStore.cs b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkScopeStore.cs
@@ -368,7 +368,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkTokenStore.cs b/src/OpenIddict.EntityFramework/Stores/OpenIddictEntityFrameworkTokenStore.cs
@@ -451,7 +451,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreApplicationStore.cs b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreApplicationStore.cs
@@ -571,7 +571,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreAuthorizationStore.cs b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreAuthorizationStore.cs
@@ -528,7 +528,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreScopeStore.cs b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreScopeStore.cs
@@ -384,7 +384,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreTokenStore.cs b/src/OpenIddict.EntityFrameworkCore/Stores/OpenIddictEntityFrameworkCoreTokenStore.cs
@@ -503,7 +503,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
                 foreach (var property in document.RootElement.EnumerateObject())
                 {
-                    builder[property.Name] = property.Value;
+                    builder[property.Name] = property.Value.Clone();
                 }
 
                 return builder.ToImmutable();

diff --git a/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbApplicationStore.cs b/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbApplicationStore.cs
@@ -343,7 +343,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
             foreach (var property in document.RootElement.EnumerateObject())
             {
-                builder[property.Name] = property.Value;
+                builder[property.Name] = property.Value.Clone();
             }
 
             return new ValueTask<ImmutableDictionary<string, JsonElement>>(builder.ToImmutable());

diff --git a/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbAuthorizationStore.cs b/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbAuthorizationStore.cs
@@ -404,7 +404,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
             foreach (var property in document.RootElement.EnumerateObject())
             {
-                builder[property.Name] = property.Value;
+                builder[property.Name] = property.Value.Clone();
             }
 
             return new ValueTask<ImmutableDictionary<string, JsonElement>>(builder.ToImmutable());

diff --git a/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbScopeStore.cs b/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbScopeStore.cs
@@ -292,7 +292,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
             foreach (var property in document.RootElement.EnumerateObject())
             {
-                builder[property.Name] = property.Value;
+                builder[property.Name] = property.Value.Clone();
             }
 
             return new ValueTask<ImmutableDictionary<string, JsonElement>>(builder.ToImmutable());

diff --git a/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbTokenStore.cs b/src/OpenIddict.MongoDb/Stores/OpenIddictMongoDbTokenStore.cs
@@ -424,7 +424,7 @@ public virtual ValueTask<ImmutableDictionary<string, JsonElement>> GetProperties
 
             foreach (var property in document.RootElement.EnumerateObject())
             {
-                builder[property.Name] = property.Value;
+                builder[property.Name] = property.Value.Clone();
             }
 
             return new ValueTask<ImmutableDictionary<string, JsonElement>>(builder.ToImmutable());