Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort sign-in demands whose principal contains a standard claim with an invalid claim value type #1958

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

kevinchalet
Copy link
Member

Fixes #1956.

While it's technically a breaking change, claims added with an incorrect ClaimValueTypes resulted in non-standard tokens and errors that were sometimes hard to debug by users.

@kevinchalet kevinchalet added this to the 5.1.0 milestone Jan 17, 2024
@kevinchalet kevinchalet self-assigned this Jan 17, 2024
@kevinchalet kevinchalet merged commit cf3e960 into openiddict:dev Jan 17, 2024
6 checks passed
@kevinchalet kevinchalet deleted the claim_value_type_validation branch January 17, 2024 15:37
@kevinchalet
Copy link
Member Author

Note: sign-in demands are also aborted when specifying well-known claims with an incorrect cardinality (e.g multiple sub claims).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enforcing strict ClaimValueTypes checks for standard claims
1 participant