Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloned Velusia to Rentor for customized class sample & integer TKey #139

Closed
wants to merge 1 commit into from

Conversation

mlhDevelopment
Copy link
Contributor

Create a sample to troubleshoot customized Application, Token, Scope, and Authorization classes, and the primary key would be an integer. This sample is the same as Velusia but with only those pieces updated.

@kevinchalet
Copy link
Member

Thanks for your PR 👍🏻

Maintaining samples has a cost and it's not clear to me whether having a dedicated sample for a such a specific scenario makes sense. Instead, could that be covered by a dedicated page in the documentation?

@mlhDevelopment
Copy link
Contributor Author

Yes, not a problem. I made this mostly for my own research and since it was basically complete sent it as a PR. No need for white elephants, I agree.

@kevinchalet
Copy link
Member

I still think it would be valuable to have that somewhere. openiddict/openiddict-documentation#9 tracks adding some documentation (likely a single page) for this scenario. Would you be interested in taking it? 😃

@mlhDevelopment
Copy link
Contributor Author

Yes, I'll give it a shot but may be slow.

@mlhDevelopment mlhDevelopment deleted the Rentor branch August 23, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants