Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the login and initialization logic to prevent the SD… #889

Merged
merged 8 commits into from
Mar 20, 2025

Conversation

FGadvancer
Copy link
Member

…K from crashing due to being uninitialized or not logged in.

🅰 Please add the issue ID after "Fixes #"

Fixes #885

…K from crashing due to being uninitialized or not logged in.

Signed-off-by: Gordon <[email protected]>
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2025
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@FGadvancer FGadvancer added this to the v3.8.4 milestone Mar 18, 2025
@FGadvancer FGadvancer merged commit 95ef7c8 into openimsdk:main Mar 20, 2025
6 of 7 checks passed
FGadvancer added a commit to FGadvancer/openim-sdk-core that referenced this pull request Mar 20, 2025
openimsdk#889)

* refactor: change the login and initialization logic to prevent the SDK from crashing due to being uninitialized or not logged in.

Signed-off-by: Gordon <[email protected]>

* fix: integ test

* fix: integ test

* fix: integ test

* fix: integ test

* refactor: change the login and initialization logic to prevent the SDK from crashing due to being uninitialized or not logged in.

Signed-off-by: Gordon <[email protected]>

* refactor: remove some unused functions and struct.

Signed-off-by: Gordon <[email protected]>

---------

Signed-off-by: Gordon <[email protected]>
Co-authored-by: icey-yu <[email protected]>
Signed-off-by: Gordon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] panic: runtime error: invalid memory address or nil pointer dereference
2 participants