-
Notifications
You must be signed in to change notification settings - Fork 30
Proposal for supporting Float4.of for CPU host code and GPU device code #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jfumero! A progress list of the required criteria for merging this PR into |
|
@jjfumero This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
PR ready and passing for both OpenCL and CUDA. |
|
/integrate |
|
Going to push as commit 420c933. |
This PR adds support for creating float4 objects within the device code:
In addition, it provides a CPU implementation for this type a new method to operate in
lanewise. This operation is CPU only at the moment:Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/642/head:pull/642$ git checkout pull/642Update a local copy of the PR:
$ git checkout pull/642$ git pull https://git.openjdk.org/babylon.git pull/642/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 642View PR using the GUI difftool:
$ git pr show -t 642Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/642.diff
Using Webrev
Link to Webrev Comment