Skip to content

Conversation

@jjfumero
Copy link
Member

@jjfumero jjfumero commented Oct 24, 2025

This PR adds support for creating float4 objects within the device code:

Float4 f = Float4.of(x, y, z ,w)

In addition, it provides a CPU implementation for this type a new method to operate in lanewise. This operation is CPU only at the moment:

Float4 vA ... 
Float4 vB ... 
Float4 vC = vA.linewise(vB, Float::sum);

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/642/head:pull/642
$ git checkout pull/642

Update a local copy of the PR:
$ git checkout pull/642
$ git pull https://git.openjdk.org/babylon.git pull/642/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 642

View PR using the GUI difftool:
$ git pr show -t 642

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/642.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

👋 Welcome back jfumero! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@jjfumero This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Proposal for supporting Float4.of for CPU host code and GPU device code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@jjfumero jjfumero marked this pull request as ready for review October 27, 2025 10:05
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

@jjfumero
Copy link
Member Author

PR ready and passing for both OpenCL and CUDA.

@jjfumero
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 31, 2025

Going to push as commit 420c933.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2025
@openjdk openjdk bot closed this Oct 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2025
@openjdk
Copy link

openjdk bot commented Oct 31, 2025

@jjfumero Pushed as commit 420c933.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jjfumero jjfumero deleted the hat/float4/of branch October 31, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant