Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350398: [s390x] Relativize initial_sp/monitors in interpreter frames #23708

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Feb 20, 2025

s390x port for JDK-8315966.

This PR depends on #23660 because index calculation macro will be added by that PR, which is being used by this one.

// Frame slot index relative to fp
#define _z_ijava_idx(_component) \
        (_z_ijava_state_neg(_component) >> LogBytesPerWord)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350398: [s390x] Relativize initial_sp/monitors in interpreter frames (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23708/head:pull/23708
$ git checkout pull/23708

Update a local copy of the PR:
$ git checkout pull/23708
$ git pull https://git.openjdk.org/jdk.git pull/23708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23708

View PR using the GUI difftool:
$ git pr show -t 23708

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23708.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2025

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8350398 8350398: [s390x] Relativize initial_sp/monitors in interpreter frames Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant